cory/tildefriends
4
5
Fork 1
Code Issues 28 Pull Requests 1 Actions Releases 25 Wiki Activity

Add prettier to the project #32

Closed
tasiaiso wants to merge 0 commits from tasiaiso:prettier into main
pull from: tasiaiso:prettier
merge into: cory:main
Conversation 2 Commits - Files Changed -
tasiaiso commented 2024-02-22 09:41:33 -05:00
Contributor
Copy Link

To format the core and apps folders

To format the core and apps folders
tasiaiso added 2 commits 2024-02-22 09:41:33 -05:00
tasiaiso added 1 commit 2024-02-22 15:27:57 -05:00
tasiaiso added 1 commit 2024-02-22 15:31:32 -05:00
tasiaiso commented 2024-02-22 15:32:23 -05:00
Author
Contributor
Copy Link

Ready to merge if you're OK with the configuration file at .prettierrc.yaml

Ready to merge if you're OK with the configuration file at .prettierrc.yaml
cory requested changes 2024-02-22 20:31:40 -05:00
cory left a comment
Owner
Copy Link

Interesting!

I honestly really appreciate the attention to process here but also I panic a little inside when I see every line change.

Would it be fair to ask you to submit the request with just the configuration+build changes so that I can apply the reformatting on my own?

Interesting! I honestly really appreciate the attention to process here but also I panic a little inside when I see every line change. Would it be fair to ask you to submit the request with just the configuration+build changes so that I can apply the reformatting on my own?
apps/admin.json Outdated
@ -2,3 +1,2 @@
"emoji": "🎛"
}
"type": "tildefriends-app",
cory commented 2024-02-22 20:22:52 -05:00
Owner
Copy Link

Oh good grief. I'll make Tilde Friends export these with tabs.

Oh good grief. I'll make Tilde Friends export these with tabs.
tasiaiso marked this conversation as resolved
apps/admin/index.html Outdated
@ -1,10 +1,12 @@
<!DOCTYPE html>
<!doctype html>
cory commented 2024-02-22 20:28:01 -05:00
Owner
Copy Link

I spent a few minutes investigating this one, and I'm a little annoyed just at the world that this is even a thing.

I spent a few minutes investigating this one, and I'm a little annoyed just at the world that this is even a thing.
tasiaiso marked this conversation as resolved
docs/guide.md Outdated
@ -6,3 +5,1 @@
terminal interface, typically with a big text output box covering most of the
page and an input box at the bottom, into which text or commands can be
entered. A script runs to produce text output and consume user input.
When you visit Tilde Friends in a web browser, you are presented with a terminal interface, typically with a big text output box covering most of the page and an input box at the bottom, into which text or commands can be entered. A script runs to produce text output and consume user input.
cory commented 2024-02-22 20:21:50 -05:00
Owner
Copy Link

My gut is that I'd prefer these to stay wrapped.

A cursory look at the prettier docs says that the relevant option is proseWrap, and the default is preserve, which should have left these alone.

Perhaps I want that set to always? What am I missing?

My gut is that I'd prefer these to stay wrapped. A cursory look at the prettier docs says that the relevant option is `proseWrap`, and the default is `preserve`, which should have left these alone. Perhaps I want that set to `always`? What am I missing?
tasiaiso commented 2024-02-23 04:49:50 -05:00
Author
Contributor
Copy Link

I did that manually, I didn't realize this was an option in the documentation.

I did that because it'd look better if you're reading this on a small display so it doesn't wrap at random places. It's reverted now.

I did that manually, I didn't realize this was an option in the documentation. I did that because it'd look better if you're reading this on a small display so it doesn't wrap at random places. It's reverted now.
tasiaiso marked this conversation as resolved
tasiaiso added 1 commit 2024-02-23 04:38:47 -05:00 
This reverts commit 41024ddb79.
tasiaiso added 1 commit 2024-02-23 04:42:38 -05:00
tasiaiso commented 2024-02-23 04:50:39 -05:00
Author
Contributor
Copy Link

I reverted most of the changes made by Prettier. You should be able to push your changes on my branch.

I reverted most of the changes made by Prettier. You should be able to push your changes on my branch.
tasiaiso added 1 commit 2024-02-23 04:50:51 -05:00
tasiaiso requested review from cory 2024-02-23 04:51:43 -05:00
cory closed this pull request 2024-02-24 11:13:23 -05:00
tasiaiso deleted branch prettier 2024-02-24 16:21:20 -05:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
cory
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cory/tildefriends#32
No description provided.
Delete Branch "tasiaiso:prettier"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?