~core/follow/ tries to parse non-JSON out of messages.content and explodes #94

New Issue

interfect · 2025-01-01T15:21:12-05:00

interfect commented

2025-01-01 15:21:12 -05:00

Whenever I go to http://127.0.0.1:12345/~core/follow/ on TildeFriends 0.0.26, I get an error:

ERROR:

⚠️ unexpected character
    at <input>:1
    at parse (native)
    at contacts_internal (app.js:27)

here's a screenshot of it happening.

According to the code, it is trying to parse JSON from the content column of the messages table at this point. So something other than JSON has managed to get into that table and also survive the json_extract query on content?

If I stick in:

throw new Error("Boom! " + row.content);

Then I get:

ERROR:

⚠️ Boom! �WGtypewcontactwcontact�5@c1WLS0y45ZnAKogdOQDfOyrGyeMm/pVJhhzCcxCVHbo=.ed25519�ollowing
    at contacts_internal (app.js:27)

Which is indeed not JSON.

Whenever I go to http://127.0.0.1:12345/~core/follow/ on TildeFriends 0.0.26, I get an error: ``` ERROR: ⚠️ unexpected character at <input>:1 at parse (native) at contacts_internal (app.js:27) ``` here's a screenshot of it happening. ![Screenshot 2025-01-01 135156.png](/attachments/bbaff53d-8dd6-4c96-86da-deaaf124b7f8) According to the code, it is trying to parse JSON from the `content` column of the `messages` table at this point. So something other than JSON has managed to get into that table and also survive the `json_extract` query on `content`? If I stick in: ``` throw new Error("Boom! " + row.content); ``` Then I get: ``` ERROR: ⚠️ Boom! �WGtypewcontactwcontact�5@c1WLS0y45ZnAKogdOQDfOyrGyeMm/pVJhhzCcxCVHbo=.ed25519�ollowing at contacts_internal (app.js:27) ``` Which is indeed not JSON.

Screenshot 2025-01-01 135156.png

86 KiB

interfect commented

2025-01-01 15:26:46 -05:00

I think we meant to SELECT json(content) FROM messages AS content, and not SELECT content FROM messages, because internally it is JSONB and you need the function to convert to text.

I think we meant to `SELECT json(content) FROM messages AS content`, and not `SELECT content FROM messages`, because internally it is JSONB and [you need the function to convert to text](https://sqlite.org/json1.html#jmini).

cory referenced this issue from a commit

2025-01-01 15:28:25 -05:00

follow: This app had never been updated since jsonb, whoops. #94

interfect commented

2025-01-01 15:29:03 -05:00

Nope it has to be SELECT json(content) AS content FROM messages, but that works.

Nope it has to be `SELECT json(content) AS content FROM messages`, but that works.

cory commented

2025-01-01 15:29:12 -05:00

Yep, that's exactly it. A while back I migrated that column to jsonb and never updated that particular app. Oops! Thanks.

🚀 1

cory closed this issue