Bug: Commonmark is broken #37

New Issue

tasiaiso · 2024-02-26T10:39:44-05:00

tasiaiso commented

2024-02-26 10:39:44 -05:00

This commit broke the apps that rely on CommonMark. I could only replicate it on those who import it with import * as commonmark from './commonmark.min.js'; and not with <script src="commonmark.min.js"></script>, so that is most likely due to how CommonMark exports its methods and classes.

Uncaught (in promise) TypeError: commonmark.Parser is not a constructor

import * as commonmark from './commonmark.min.js';

print(JSON.stringify(commonmark))
> {}

[This commit](https://dev.tildefriends.net/cory/tildefriends/commit/165f25db69fd5f674cc57bf6d4265d823dfbadf6) broke the apps that rely on CommonMark. I could only replicate it on those who import it with `import * as commonmark from './commonmark.min.js';` and not with `<script src="commonmark.min.js"></script>`, so that is most likely due to how CommonMark exports its methods and classes. `Uncaught (in promise) TypeError: commonmark.Parser is not a constructor` ``` import * as commonmark from './commonmark.min.js'; print(JSON.stringify(commonmark)) > {} ```

cory commented

2024-02-26 12:39:22 -05:00

You're right. I tried to test exactly for that but missed somehow. Thanks. Reverted until I can sort myself out.

7bcdbd3813

You're right. I tried to test exactly for that but missed somehow. Thanks. Reverted until I can sort myself out. 7bcdbd381398332564a1278f87838c8ae64579c6

cory closed this issue

2024-02-26 12:39:32 -05:00

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cory/tildefriends#37