ssb: More uv_async_send paranoia still. #96

.gitea/workflows/build.yaml

@@ -31,7 +31,7 @@ jobs:
         with:
           path: |
             out/TildeFriends-release.fdroid.apk
-            out/winrelease/tildefriends.exe
+            out/winrelease/tildefriends.standalone.exe
             out/tildefriends-x86_64.AppImage
             out/release/tildefriends.standalone
             out/armrelease/tildefriends.standalone

GNUmakefile

@@ -127,6 +127,7 @@ WINDOWS_TARGETS := \
 	out/winrelease/tildefriends.exe
 ifeq ($(HAVE_WIN),1)
 BUILD_TYPES += windebug winrelease
+all: out/windebug/tildefriends.standalone.exe out/winrelease/tildefriends.standalone.exe
 endif
 
 AARCH64_TARGETS := \
@@ -1091,6 +1092,7 @@ out/%.app/tildefriends.png: src/ios/tildefriends.png
 	@cp -v $< $@
 
 out/data.zip: $(RAW_FILES)
+	@echo [zip] $@
 	@zip -u $@ -q -9 $(RAW_FILES)
 
 out/tildefriends-%.app/tildefriends: out/%/tildefriends out/tildefriends-%.app/Info.plist out/tildefriends-%.app/tildefriends.png out/data.zip

src/ssb.c

@@ -2719,7 +2719,8 @@ static void _tf_ssb_connection_finalizer(JSRuntime* runtime, JSValue value)
 static void _tf_ssb_connection_process_message_async(uv_async_t* async)
 {
 	tf_ssb_connection_t* connection = async->data;
-	if (!connection->is_closing && _tf_ssb_connection_box_stream_recv(connection))
+	/* The receive may initiate a close, so this order is important. */
+	if (_tf_ssb_connection_box_stream_recv(connection) && !connection->is_closing)
 	{
 		uv_async_send(&connection->async);
 	}