From f79d7b35a4d143180d35460eb5003979cde55349 Mon Sep 17 00:00:00 2001
From: Cory McWilliams <cory@unprompted.com>
Date: Tue, 14 May 2024 12:41:17 -0400
Subject: [PATCH] Disallow creating accounts as a guest. #52

---
 apps/identity/app.js | 2 +-
 core/client.js       | 2 +-
 core/core.js         | 5 ++++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/apps/identity/app.js b/apps/identity/app.js
index 6ed964af..274f9228 100644
--- a/apps/identity/app.js
+++ b/apps/identity/app.js
@@ -78,7 +78,7 @@ async function main() {
 					alert('Successfully created: ' + id);
 					await tfrpc.rpc.reload();
 				} catch (e) {
-					alert('Error creating identity: ' + e);
+					alert('Error creating identity: ' + e.message);
 				}
 			}
 			handler.hide_id = function hide_id(event, element) {
diff --git a/core/client.js b/core/client.js
index e0e692a1..15ad38b0 100644
--- a/core/client.js
+++ b/core/client.js
@@ -208,7 +208,7 @@ class TfNavigationElement extends LitElement {
 					</div>
 				</div>
 			`;
-		} else {
+		} else if (this.credentials?.session?.name && this.credentials.session.name !== 'guest') {
 			return html`
 				<link type="text/css" rel="stylesheet" href="/static/w3.css" />
 				<button
diff --git a/core/core.js b/core/core.js
index 3a042aef..f4235192 100644
--- a/core/core.js
+++ b/core/core.js
@@ -577,7 +577,8 @@ async function getProcessBlob(blobId, key, options) {
 				if (
 					process.credentials &&
 					process.credentials.session &&
-					process.credentials.session.name
+					process.credentials.session.name &&
+					process.credentials.session.name !== 'guest'
 				) {
 					let id = ssb.createIdentity(process.credentials.session.name);
 					await process.sendIdentities();
@@ -595,6 +596,8 @@ async function getProcessBlob(blobId, key, options) {
 						]
 					);
 					return id;
+				} else {
+					throw new Error('Must be signed-in to create an account.');
 				}
 			};
 			if (process.credentials?.permissions?.administration) {