cory/tildefriends
5
6
Fork 2
Code Issues 36 Pull Requests Actions Releases 30 Wiki Activity

ssb: Commit messages in transactions for performance.
All checks were successful
Build Tilde Friends / Build-All (push) Successful in 30m39s
Details

Browse Source
This commit is contained in:
Cory McWilliams 2025-03-18 12:49:47 -04:00
parent 7f34b585d3
commit e92c439724
1 changed files with 79 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
src/ssb.db.c
View File

@ -23,6 +23,17 @@ typedef struct _message_store_t message_store_t;
static void _tf_ssb_db_store_message_after_work(tf_ssb_t* ssb, int status, void* user_data); static void _tf_ssb_db_store_message_after_work(tf_ssb_t* ssb, int status, void* user_data);
static int _tf_ssb_db_try_exec(sqlite3* db, const char* statement)
{
char* error = NULL;
int result = sqlite3_exec(db, statement, NULL, NULL, &error);
if (result != SQLITE_OK)
{
tf_printf("Error running '%s': %s.\n", statement, error ? error : sqlite3_errmsg(db));
}
return result;
}
static void _tf_ssb_db_exec(sqlite3* db, const char* statement) static void _tf_ssb_db_exec(sqlite3* db, const char* statement)
{ {
char* error = NULL; char* error = NULL;
@ -412,10 +423,9 @@ static bool _tf_ssb_db_previous_message_exists(sqlite3* db, const char* author,
return exists; return exists;
} }
static int64_t _tf_ssb_db_store_message_raw(tf_ssb_t* ssb, const char* id, const char* previous, const char* author, int64_t sequence, double timestamp, const char* content, static int64_t _tf_ssb_db_store_message_raw(sqlite3* db, const char* id, const char* previous, const char* author, int64_t sequence, double timestamp, const char* content,
size_t content_len, const char* signature, int flags) size_t content_len, const char* signature, int flags)
{ {
sqlite3* db = tf_ssb_acquire_db_writer(ssb);
int64_t last_row_id = -1; int64_t last_row_id = -1;
bool id_mismatch = false; bool id_mismatch = false;
@ -464,7 +474,6 @@ static int64_t _tf_ssb_db_store_message_raw(tf_ssb_t* ssb, const char* id, const
*/ */
tf_printf("%p: Previous message doesn't exist for author=%s sequence=%" PRId64 " previous=%s.\n", db, author, sequence, previous); tf_printf("%p: Previous message doesn't exist for author=%s sequence=%" PRId64 " previous=%s.\n", db, author, sequence, previous);
} }
tf_ssb_release_db_writer(ssb, db);
return last_row_id; return last_row_id;
} }
@ -537,30 +546,47 @@ typedef struct _message_store_t
static void _tf_ssb_db_store_message_work(tf_ssb_t* ssb, void* user_data) static void _tf_ssb_db_store_message_work(tf_ssb_t* ssb, void* user_data)
{ {
message_store_t* store = user_data; message_store_t* store = user_data;
int64_t last_row_id = _tf_ssb_db_store_message_raw( sqlite3* db = tf_ssb_acquire_db_writer(ssb);
ssb, store->id, *store->previous ? store->previous : NULL, store->author, store->sequence, store->timestamp, store->content, store->length, store->signature, store->flags); bool in_transaction = _tf_ssb_db_try_exec(db, "BEGIN TRANSACTION") == SQLITE_OK;
while (store)
{
int64_t last_row_id = _tf_ssb_db_store_message_raw(db, store->id, *store->previous ? store->previous : NULL, store->author, store->sequence, store->timestamp,
store->content, store->length, store->signature, store->flags);
if (last_row_id != -1) if (last_row_id != -1)
{ {
store->out_stored = true; store->out_stored = true;
store->out_blob_wants = _tf_ssb_db_get_message_blob_wants(ssb, last_row_id); store->out_blob_wants = _tf_ssb_db_get_message_blob_wants(ssb, last_row_id);
} }
store = store->next;
}
if (in_transaction)
{
if (_tf_ssb_db_try_exec(db, "COMMIT TRANSACTION") != SQLITE_OK)
{
store = user_data;
while (store)
{
store->out_stored = false;
store = store->next;
}
}
}
tf_ssb_release_db_writer(ssb, db);
} }
static void _wake_up_queue(tf_ssb_t* ssb, tf_ssb_store_queue_t* queue) static void _wake_up_queue(tf_ssb_t* ssb, tf_ssb_store_queue_t* queue)
{ {
if (!queue->running) if (!queue->running)
{ {
message_store_t* next = queue->head; message_store_t* stores = queue->head;
if (next) queue->head = NULL;
{
queue->head = next->next;
if (queue->tail == next)
{
queue->tail = NULL; queue->tail = NULL;
} if (stores)
next->next = NULL; {
queue->running = true; queue->running = true;
tf_ssb_run_work(ssb, _tf_ssb_db_store_message_work, _tf_ssb_db_store_message_after_work, next); tf_ssb_run_work(ssb, _tf_ssb_db_store_message_work, _tf_ssb_db_store_message_after_work, stores);
} }
} }
} }
@ -569,6 +595,9 @@ static void _tf_ssb_db_store_message_after_work(tf_ssb_t* ssb, int status, void*
{ {
message_store_t* store = user_data; message_store_t* store = user_data;
tf_trace_t* trace = tf_ssb_get_trace(ssb); tf_trace_t* trace = tf_ssb_get_trace(ssb);
while (store)
{
if (store->out_stored) if (store->out_stored)
{ {
tf_trace_begin(trace, "notify_message_added"); tf_trace_begin(trace, "notify_message_added");
@ -602,10 +631,14 @@ static void _tf_ssb_db_store_message_after_work(tf_ssb_t* ssb, int status, void*
store->callback(store->id, store->out_stored, store->user_data); store->callback(store->id, store->out_stored, store->user_data);
} }
JS_FreeCString(context, store->content); JS_FreeCString(context, store->content);
message_store_t* last = store;
store = store->next;
tf_free(last);
}
tf_ssb_store_queue_t* queue = tf_ssb_get_store_queue(ssb); tf_ssb_store_queue_t* queue = tf_ssb_get_store_queue(ssb);
queue->running = false; queue->running = false;
_wake_up_queue(ssb, queue); _wake_up_queue(ssb, queue);
tf_free(store);
} }
void tf_ssb_db_store_message( void tf_ssb_db_store_message(