From 8edc9aaa63fa8eaa710d0b8b52734082112631d1 Mon Sep 17 00:00:00 2001 From: Cory McWilliams Date: Sun, 14 Aug 2022 17:34:27 +0000 Subject: [PATCH] Make permissionTest() throw an error on fail. Having to remember to check the value scares me too much. git-svn-id: https://www.unprompted.com/svn/projects/tildefriends/trunk@3960 ed5197a5-7fde-0310-b194-c3ffbd925b24 --- core/core.js | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/core/core.js b/core/core.js index 48919692..8b4abb78 100644 --- a/core/core.js +++ b/core/core.js @@ -215,7 +215,7 @@ async function getProcessBlob(blobId, key, options) { if (gGlobalSettings.userPermissions[user][options.packageOwner][options.packageName][permission]) { return true; } else { - return false; + throw Error(`Permission denied: ${permission}.`); } } else { @@ -227,13 +227,11 @@ async function getProcessBlob(blobId, key, options) { return true; } else if (value == 'deny') { storePermission(user, options.packageOwner, options.packageName, permission, false); - return false; + throw Error(`Permission denied: ${permission}.`); } else if (value == 'deny once') { - return false; + throw Error(`Permission denied: ${permission}.`); } - return false; - }).catch(function() { - return false; + throw Error(`Permission denied: ${permission}.`); }); } }, @@ -296,10 +294,8 @@ async function getProcessBlob(blobId, key, options) { if (process.credentials && process.credentials.session && process.credentials.session.name) { - return imports.core.permissionTest('ssb_append').then(function(value) { - if (value) { - return ssb.appendMessageWithIdentity(process.credentials.session.name, id, message); - } + return imports.core.permissionTest('ssb_append').then(function() { + return ssb.appendMessageWithIdentity(process.credentials.session.name, id, message); }); } };