cory/tildefriends
4
5
Fork 1
Code Issues 31 Pull Requests 1 Actions Releases 24 Wiki Activity

Minor cleanup.

Browse Source
This commit is contained in:
Cory McWilliams 2024-07-04 13:18:23 -04:00
parent ed6bef6d24
commit 50b54599ef
2 changed files with 39 additions and 64 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/main.c
View File

@ -629,7 +629,6 @@ static int _tf_command_sandbox(const char* file, int argc, char* argv[])
show_usage = true; show_usage = true;
break; break;
case 'f': case 'f':
tf_printf("got -f %s\n", optarg);
fd = atoi(optarg); fd = atoi(optarg);
break; break;
} }

44
src/taskstub.js.c
View File

@ -122,10 +122,11 @@ static JSValue _taskstub_create(JSContext* context, JSValueConst this_val, int a
char arg1[] = "sandbox"; char arg1[] = "sandbox";
char* command_argv[] = { _executable, arg1, 0 }; char* command_argv[] = { _executable, arg1, 0 };
tf_android_start_service_t* start_service = tf_task_get_android_start_service();
JSValue result = JS_NULL; JSValue result = JS_NULL;
if (tf_task_get_one_proc(parent)) if (tf_task_get_one_proc(parent) || start_service)
{ {
uv_os_sock_t fds[2]; uv_os_sock_t fds[2] = { 0 };
int pipe_result = uv_socketpair(SOCK_STREAM, 0, fds, 0, 0); int pipe_result = uv_socketpair(SOCK_STREAM, 0, fds, 0, 0);
if (pipe_result) if (pipe_result)
{ {
@ -133,7 +134,7 @@ static JSValue _taskstub_create(JSContext* context, JSValueConst this_val, int a
} }
uv_pipe_t* pipe = tf_packetstream_get_pipe(stub->_stream); uv_pipe_t* pipe = tf_packetstream_get_pipe(stub->_stream);
memset(pipe, 0, sizeof(*pipe)); *pipe = (uv_pipe_t) { 0 };
pipe_result = uv_pipe_init(tf_task_get_loop(parent), pipe, 1); pipe_result = uv_pipe_init(tf_task_get_loop(parent), pipe, 1);
if (pipe_result != 0) if (pipe_result != 0)
{ {
@ -145,41 +146,17 @@ static JSValue _taskstub_create(JSContext* context, JSValueConst this_val, int a
tf_printf("uv_pipe_open failed: %s\n", uv_strerror(pipe_result)); tf_printf("uv_pipe_open failed: %s\n", uv_strerror(pipe_result));
} }
uv_thread_t* thread = tf_malloc(sizeof(uv_thread_t)); if (start_service)
uv_thread_create(thread, _tf_taskstub_run_sandbox_thread, (void*)(intptr_t)fds[1]); {
start_service(fds[1]);
tf_packetstream_set_on_receive(stub->_stream, tf_task_on_receive_packet, stub);
tf_packetstream_start(stub->_stream);
result = taskObject;
} }
else else
{ {
tf_android_start_service_t* start_service = tf_task_get_android_start_service(); /* XXX: This is a leak. */
if (start_service) uv_thread_t* thread = tf_malloc(sizeof(uv_thread_t));
{ uv_thread_create(thread, _tf_taskstub_run_sandbox_thread, (void*)(intptr_t)fds[1]);
uv_os_sock_t fds[2];
int socketpair_result = uv_socketpair(SOCK_STREAM, 0, fds, 0, 0);
if (socketpair_result)
{
tf_printf("uv_socketpair: %s\n", uv_strerror(socketpair_result));
} }
uv_pipe_t* pipe = tf_packetstream_get_pipe(stub->_stream);
*pipe = (uv_pipe_t) { 0 };
if (uv_pipe_init(tf_task_get_loop(parent), pipe, 1) != 0)
{
tf_printf("uv_pipe_init failed\n");
}
int pipe_result = uv_pipe_open(pipe, fds[0]);
if (pipe_result)
{
tf_printf("uv_pipe_open: %s\n", uv_strerror(pipe_result));
}
start_service(fds[1]);
stub->_process.data = stub;
tf_packetstream_set_on_receive(stub->_stream, tf_task_on_receive_packet, stub); tf_packetstream_set_on_receive(stub->_stream, tf_task_on_receive_packet, stub);
tf_packetstream_start(stub->_stream); tf_packetstream_start(stub->_stream);
result = taskObject; result = taskObject;
@ -223,7 +200,6 @@ static JSValue _taskstub_create(JSContext* context, JSValueConst this_val, int a
JS_FreeValue(context, taskObject); JS_FreeValue(context, taskObject);
} }
} }
}
return JS_DupValue(context, result); return JS_DupValue(context, result);
} }