cory/tildefriends
4
5
Fork 1
Code Issues 32 Pull Requests 1 Actions Releases 26 Wiki Activity

Fix some easy leaks reported by asan.

Browse Source 
git-svn-id: https://www.unprompted.com/svn/projects/tildefriends/trunk@3411 ed5197a5-7fde-0310-b194-c3ffbd925b24
This commit is contained in:
Cory McWilliams 2017-11-18 23:02:08 +00:00
parent 0ef8a8919a
commit 2bc62b2ecd
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/PacketStream.cpp
View File

@ -60,10 +60,10 @@ void PacketStream::onRead(uv_stream_t* handle, ssize_t count, const uv_buf_t* bu
owner->_buffer.insert(owner->_buffer.end(), buffer->base, buffer->base + count); owner->_buffer.insert(owner->_buffer.end(), buffer->base, buffer->base + count);
owner->processMessages(); owner->processMessages();
} }
delete[] reinterpret_cast<char*>(buffer->base);
} else { } else {
owner->close(); owner->close();
} }
delete[] reinterpret_cast<char*>(buffer->base);
} }
void PacketStream::processMessages() { void PacketStream::processMessages() {

4
src/Task.cpp
View File

@ -98,6 +98,7 @@ Task::Task() {
++_count; ++_count;
v8::Isolate::CreateParams options; v8::Isolate::CreateParams options;
options.array_buffer_allocator = v8::ArrayBuffer::Allocator::NewDefaultAllocator(); options.array_buffer_allocator = v8::ArrayBuffer::Allocator::NewDefaultAllocator();
_allocator = options.array_buffer_allocator;
_isolate = v8::Isolate::New(options); _isolate = v8::Isolate::New(options);
_isolate->SetData(0, this); _isolate->SetData(0, this);
_isolate->SetCaptureStackTraceForUncaughtExceptions(true, 16); _isolate->SetCaptureStackTraceForUncaughtExceptions(true, 16);
@ -117,6 +118,9 @@ Task::~Task() {
_isolate->Dispose(); _isolate->Dispose();
_isolate = 0; _isolate = 0;
delete _allocator;
_allocator = nullptr;
uv_loop_delete(_loop); uv_loop_delete(_loop);
--_count; --_count;
} }

2
src/Task.h
View File

@ -103,6 +103,8 @@ private:
v8::Persistent<v8::Object, v8::CopyablePersistentTraits<v8::Object> > _exportObject; v8::Persistent<v8::Object, v8::CopyablePersistentTraits<v8::Object> > _exportObject;
v8::Persistent<v8::Object, v8::CopyablePersistentTraits<v8::Object> > _sourceObject; v8::Persistent<v8::Object, v8::CopyablePersistentTraits<v8::Object> > _sourceObject;
v8::ArrayBuffer::Allocator* _allocator;
v8::Handle<v8::Object> getStatistics(); v8::Handle<v8::Object> getStatistics();
std::string resolveRequire(const std::string& require); std::string resolveRequire(const std::string& require);